SuwayomiServer: Bump Java to v21, code formating (#3987)

* Bump java to v21, code formating

* Refactoring

* Update

* Update

* Update suwayomiserver.sh

---------

Co-authored-by: CanbiZ <47820557+MickLesk@users.noreply.github.com>

install/suwayomiserver-install.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 
 # Copyright (c) 2021-2025 community-scripts ORG
-# Author: tremor021
+# Author: Slaviša Arežina (tremor021)
 # License: MIT | https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
 # Source: https://github.com/Suwayomi/Suwayomi-Server
 
@@ -14,18 +14,19 @@ network_check
 update_os
 
 msg_info "Installing Dependencies"
-$STD apt-get install -y \
-  openjdk-17-jre \
-  libc++-dev
+$STD apt-get install -y libc++-dev
 msg_ok "Installed Dependencies"
 
+JAVA_VERSION=21 install_java
+
 msg_info "Settting up Suwayomi-Server"
-URL=$(curl -fsSL https://api.github.com/repos/Suwayomi/Suwayomi-Server/releases/latest | grep "browser_download_url" | awk '{print substr($2, 2, length($2)-2) }' | tail -n+2 | head -n 1)
+temp_file=$(mktemp)
 RELEASE=$(curl -fsSL https://api.github.com/repos/Suwayomi/Suwayomi-Server/releases/latest | grep "tag_name" | awk '{print substr($2, 2, length($2)-3) }')
-curl -fsSL "$URL" -o $(basename "$URL")
-$STD dpkg -i *.deb
-echo ${RELEASE} >/opt/suwayomi-server_version.txt
+curl -fsSL "https://github.com/Suwayomi/Suwayomi-Server/releases/download/${RELEASE}/Suwayomi-Server-${RELEASE}-debian-all.deb" -o "$temp_file"
+$STD dpkg -i "$temp_file"
+echo "${RELEASE}" >/opt/suwayomi-server_version.txt
 msg_ok "Done setting up Suwayomi-Server"
+
 msg_info "Creating Service"
 cat <<EOF >/etc/systemd/system/suwayomi-server.service
 [Unit]
@@ -41,10 +42,12 @@ WantedBy=multi-user.target
 EOF
 systemctl enable -q --now suwayomi-server
 msg_ok "Created Service"
+
 motd_ssh
 customize
+
 msg_info "Cleaning up"
-rm -f *.deb
+rm -f "$temp_file"
 $STD apt-get -y autoremove
 $STD apt-get -y autoclean
 msg_ok "Cleaned"