keep homemade head units without a certificate working, and read wheel buttons and the knob as main does

gearslip/src/main/java/app/seb3thehacker/gearslip/GearslipRunner.kt

@@ -888,9 +888,8 @@ class GearslipRunner(
         for (key in Wire.allBytes(Wire.fields(keyEvent), 1)) {
             val fields = Wire.fields(key)
             val keycode = Wire.varint(fields, 1)?.toInt() ?: continue
-            val down = (Wire.varint(fields, 2) ?: continue) != 0L
+            val down = Wire.varint(fields, 2) == 1L
-            if (Wire.varint(fields, 3) == null) continue
+            val longPress = Wire.varint(fields, 4) == 1L
-            val longPress = (Wire.varint(fields, 4) ?: 0L) != 0L
             log.i("<- key event: keycode=$keycode ${if (down) "down" else "up"}${if (longPress) " long" else ""}")
             if (!CarKeys.onKey(keycode, down, longPress) && down) log.i("unhandled keycode=$keycode")
         }
@@ -906,7 +905,6 @@ class GearslipRunner(
             val keycode = Wire.varint(fields, 1)?.toInt() ?: continue
             // int32, so a turn the other way arrives as a 64-bit two's complement varint.
             val delta = Wire.varint(fields, 2)?.toInt() ?: continue
-            if (keycode != 65536 || delta == 0) continue
             log.i("<- relative event: keycode=$keycode delta=$delta")
             CarKeys.onRotate(delta)
         }

gearslip/src/main/java/app/seb3thehacker/gearslip/PhoneTls.kt

@@ -38,9 +38,11 @@ class PhoneTls(keyStore: KeyStore, password: CharArray) {
 
         engine = context.createSSLEngine().apply {
             useClientMode = false
-            // Android Auto's phone endpoint requires the head unit to present a certificate.
+            // want, not need: we ask the head unit for its certificate so the run also tells
-            needClientAuth = true
+            // us what real units present, but we never make the session depend on getting one.
-            enabledProtocols = arrayOf("TLSv1.2")
+            // Homemade head units may have none.
+            wantClientAuth = true
+            enabledProtocols = arrayOf("TLSv1.2") // aasdk pins TLS 1.2
         }
         engine.beginHandshake()
     }
@@ -172,7 +174,7 @@ class PhoneTls(keyStore: KeyStore, password: CharArray) {
                 }
             }
         } catch (_: SSLPeerUnverifiedException) {
-            log.i("head unit peer certificate is unavailable")
+            log.i("head unit presented NO certificate (we asked but did not require one)")
         }
     }
 

gearslip/src/test/java/app/seb3thehacker/gearslip/CryptoTest.kt

@@ -44,11 +44,11 @@ class CryptoTest {
     }
 
     @Test
-    fun `TLS rejects a head unit that does not present a client certificate`() {
+    fun `TLS still connects a head unit that presents no certificate, as homemade ones may`() {
         val generated = SelfSignedCert.generate()
         val identity = CertProvider.Identity(generated.keyStore, generated.certificate,
             SelfSignedCert.PASSWORD, "test")
-        assertFalse(TlsSelfTest.run(identity, withClientCertificate = false))
+        assertTrue(TlsSelfTest.run(identity, withClientCertificate = false))
     }
 
     @Test